OverviewFilesCommitsIssuesDocsReleasesPeers

opencog-atomspace commits / b60acc1

Revise code design commentary
b60acc10cb5465e75c070e2155e624a1851c2f94
by Linas Vepštas <linasvepstas@gmail.com> · 2026-01-23T02:39:38.000Z

Changed files (1) +7 -2

opencog/atoms/execution/EvaluatableLink.cc +7 -2
……@@ -178,8 +178,13 @@ static ValuePtr exec_or_eval(AtomSpace* as,
178178 vp = hs[0];
179179 }
180180
181 // XXX FIXME? should we be doing the add here? Isn't this the
182 // callers reponsibility?
181 // XXX FIXME? Should we be doing the add here? Isn't this the
182 // callers reponsibility? Three unit tests fail, if we don't
183 // do the add: RandomUTest FormulaUTest SequenceUTest and one
184 // fails: SequenceUTest if we add to scratch instead of main.
185 // I'm not sure if something is buggy or not, or if this is an
186 // intentional design choice. FWIW there are many places in the
187 // code base that do something like this.
183188 // if (vp->is_atom()) scratch->add_atom(HandleCast(vp));
184189 if (vp->is_atom()) as->add_atom(HandleCast(vp));
185190 return vp;