OverviewFilesCommitsIssuesDocsReleasesPeers

opencog-atomspace-rocks commits / 0e25b37

Convert another unit test to new API
0e25b37429f71a0dea412a486684573d3a6f058a
by Linas Vepstas <linasvepstas@gmail.com> · 2026-01-18T23:56:34.000Z

Changed files (1) +44 -68

tests/persist/monospace/MonoValueSaveUTest.cxxtest +44 -68
……@@ -37,7 +37,7 @@
3737#include <opencog/atoms/value/FloatValue.h>
3838#include <opencog/atoms/value/LinkValue.h>
3939#include <opencog/atoms/value/StringValue.h>
40#include <opencog/atoms/value/FloatValue.h>
40#include <opencog/atoms/value/VoidValue.h>
4141
4242#include <opencog/persist/monospace/MonoStorage.h>
4343
……@@ -105,10 +105,10 @@ void ValueSaveUTest::test_single_atom_save()
105105{
106106 logger().info("BEGIN TEST: %s", __FUNCTION__);
107107
108 AtomSpace* as = new AtomSpace();
108 AtomSpacePtr as = createAtomSpace();
109109 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
110110 StorageNodePtr store = StorageNodeCast(hsn);
111 store->open();
111 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
112112 TS_ASSERT(store->connected())
113113
114114 Handle key = as->add_node(PREDICATE_NODE, "some pred key");
……@@ -154,8 +154,6 @@ void ValueSaveUTest::test_single_atom_save()
154154 store->store_atom(atom);
155155 store->barrier();
156156
157 delete as;
158
159157 logger().info("END TEST: %s", __FUNCTION__);
160158}
161159
……@@ -172,10 +170,10 @@ void ValueSaveUTest::check_one(ValuePtr pap, bool fetchkey)
172170 // ------
173171 // First, save the value
174172
175 AtomSpace* as = new AtomSpace();
173 AtomSpacePtr as = createAtomSpace();
176174 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
177175 StorageNodePtr store = StorageNodeCast(hsn);
178 store->open();
176 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
179177 TS_ASSERT(store->connected())
180178
181179 Handle key = store->fetch_atom(bkey);
……@@ -190,15 +188,12 @@ void ValueSaveUTest::check_one(ValuePtr pap, bool fetchkey)
190188 printf ("Stored atom %s\n", atom->to_string().c_str());
191189 printf ("Stored vals %s\n", atom->valuesToString().c_str());
192190
193 delete as;
194
195191 // ---------------------------------
196192 // Now, fetch the value and compare.
197
198 as = new AtomSpace();
193 as = createAtomSpace();
199194 hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
200195 store = StorageNodeCast(hsn);
201 store->open();
196 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
202197 TS_ASSERT(store->connected())
203198
204199 // Storage uses a different code path if the key is not yet
……@@ -212,18 +207,16 @@ void ValueSaveUTest::check_one(ValuePtr pap, bool fetchkey)
212207
213208 printf("Expecting %s\n", pap->to_string().c_str());
214209 TS_ASSERT(*pap == *fap);
215
216 delete as;
217210}
218211
219212void ValueSaveUTest::test_save_restore(bool fkey)
220213{
221214 logger().info("BEGIN TEST: %s", __FUNCTION__);
222215
223 AtomSpace* as = new AtomSpace();
216 AtomSpacePtr as = createAtomSpace();
224217 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
225218 StorageNodePtr store = StorageNodeCast(hsn);
226 store->open();
219 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
227220 TS_ASSERT(store->connected())
228221
229222 Handle key = as->add_node(PREDICATE_NODE, "some pred key");
……@@ -261,8 +254,12 @@ void ValueSaveUTest::test_save_restore(bool fkey)
261254
262255 check_one(pvl2, fkey);
263256
257 // Clean up the database
258 as = createAtomSpace();
259 hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
260 store = StorageNodeCast(hsn);
261 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
264262 store->erase();
265 delete as;
266263
267264 logger().info("END TEST: %s", __FUNCTION__);
268265}
……@@ -276,10 +273,10 @@ void ValueSaveUTest::test_load_by_type()
276273{
277274 logger().info("BEGIN TEST: %s", __FUNCTION__);
278275
279 AtomSpace* as = new AtomSpace();
276 AtomSpacePtr as = createAtomSpace();
280277 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
281278 StorageNodePtr store = StorageNodeCast(hsn);
282 store->open();
279 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
283280 TS_ASSERT(store->connected())
284281
285282 // Clear out left-over junk, just in case.
……@@ -332,15 +329,13 @@ void ValueSaveUTest::test_load_by_type()
332329 store->store_atom(al);
333330 store->store_atom(av);
334331 store->barrier();
335 delete as;
336332
337333 // --------------------
338334 // Start it up again.
339
340 as = new AtomSpace();
335 as = createAtomSpace();
341336 hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
342337 store = StorageNodeCast(hsn);
343 store->open();
338 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
344339 TS_ASSERT(store->connected())
345340
346341 // --------------------
……@@ -348,12 +343,12 @@ void ValueSaveUTest::test_load_by_type()
348343 store->fetch_all_atoms_of_type(CONCEPT_NODE);
349344 store->barrier();
350345
351 // Eight: 4 ConceptNodes, PredicateNode "*-TruthValueKey-*",
346 // Nine: 4 ConceptNodes, PredicateNode "*-TruthValueKey-*",
352347 // PredicateNode "*-IsKeyFlag-*", PredicateNode "some pred key",
353 // and the MonoStorageNode -- the preds show up when the
354 // attached values are fetched.
348 // PredicateNode "*-open-*", and the MonoStorageNode -- the preds
349 // show up when the attached values are fetched.
355350 printf ("fetched %lu atoms\n", as->get_size());
356 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 8);
351 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 9);
357352
358353 Handle gkey = as->add_node(PREDICATE_NODE, "some pred key");
359354 Handle gaf = as->add_node(CONCEPT_NODE, "float node");
……@@ -388,9 +383,6 @@ void ValueSaveUTest::test_load_by_type()
388383 TS_ASSERT(*gpl == *pvl);
389384 TS_ASSERT(*gpv == *pvv);
390385
391 // --------------------
392 delete as;
393
394386 logger().info("END TEST: %s", __FUNCTION__);
395387}
396388
……@@ -405,10 +397,10 @@ void ValueSaveUTest::test_link_by_type()
405397{
406398 logger().info("BEGIN TEST: %s", __FUNCTION__);
407399
408 AtomSpace* as = new AtomSpace();
400 AtomSpacePtr as = createAtomSpace();
409401 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
410402 StorageNodePtr store = StorageNodeCast(hsn);
411 store->open();
403 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
412404 TS_ASSERT(store->connected())
413405
414406 Handle key = as->add_node(PREDICATE_NODE, "some pred key");
……@@ -487,15 +479,12 @@ void ValueSaveUTest::test_link_by_type()
487479 store->store_atom(cv);
488480 store->barrier();
489481
490 delete as;
491
492482 // --------------------
493483 // Start it up again.
494
495 as = new AtomSpace();
484 as = createAtomSpace();
496485 hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
497486 store = StorageNodeCast(hsn);
498 store->open();
487 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
499488 TS_ASSERT(store->connected())
500489
501490 // --------------------
……@@ -513,9 +502,10 @@ void ValueSaveUTest::test_link_by_type()
513502 // only the values on the C-links should be fetched.
514503 store->fetch_all_atoms_of_type(LIST_LINK);
515504 store->barrier();
516 // +1 for *-IsKeyFlag-*
505 // 17 = 4 LIST_LINKs + 8 ConceptNodes + PredicateNode "some pred key"
506 // + *-TruthValueKey-* + *-IsKeyFlag-* + *-open-* + MonoStorageNode
517507 printf ("fetched %lu atoms\n", as->get_size());
518 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 16);
508 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 17);
519509
520510 Handle gbf = as->add_node(CONCEPT_NODE, "b float node");
521511 Handle gbt = as->add_node(CONCEPT_NODE, "b string node");
……@@ -601,9 +591,6 @@ void ValueSaveUTest::test_link_by_type()
601591 TS_ASSERT(*gpl == *pvl);
602592 TS_ASSERT(*gpv == *pvv);
603593
604 // --------------------
605 delete as;
606
607594 logger().info("END TEST: %s", __FUNCTION__);
608595}
609596
……@@ -615,10 +602,10 @@ void ValueSaveUTest::test_link_by_type_quoted()
615602{
616603 logger().info("BEGIN TEST: %s", __FUNCTION__);
617604
618 AtomSpace* as = new AtomSpace();
605 AtomSpacePtr as = createAtomSpace();
619606 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
620607 StorageNodePtr store = StorageNodeCast(hsn);
621 store->open();
608 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
622609 TS_ASSERT(store->connected())
623610
624611 Handle key = as->add_node(PREDICATE_NODE, "some (\"pred\"))) key");
……@@ -697,15 +684,12 @@ void ValueSaveUTest::test_link_by_type_quoted()
697684 store->store_atom(cv);
698685 store->barrier();
699686
700 delete as;
701
702687 // --------------------
703688 // Start it up again.
704
705 as = new AtomSpace();
689 as = createAtomSpace();
706690 hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
707691 store = StorageNodeCast(hsn);
708 store->open();
692 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
709693 TS_ASSERT(store->connected())
710694
711695 // --------------------
……@@ -724,10 +708,10 @@ void ValueSaveUTest::test_link_by_type_quoted()
724708 store->fetch_all_atoms_of_type(LIST_LINK);
725709 store->barrier();
726710
727 // We created 9 new atoms above, so expect 16 from before plus 9
728 // +1 for *-IsKeyFlag-*
729 printf ("fetched %lu atoms, expecting 25\n", as->get_size());
730 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 25);
711 // 26 = 9 new atoms above + 4 LIST_LINKs + 8 ConceptNodes (b nodes)
712 // + *-TruthValueKey-* + *-IsKeyFlag-* + *-open-* + MonoStorageNode
713 printf ("fetched %lu atoms, expecting 26\n", as->get_size());
714 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 26);
731715
732716 Handle gbf = as->add_node(CONCEPT_NODE, "b float node");
733717 Handle gbt = as->add_node(CONCEPT_NODE, "b string node");
……@@ -813,9 +797,6 @@ void ValueSaveUTest::test_link_by_type_quoted()
813797 TS_ASSERT(*gpl == *pvl);
814798 TS_ASSERT(*gpv == *pvv);
815799
816 // --------------------
817 delete as;
818
819800 logger().info("END TEST: %s", __FUNCTION__);
820801}
821802
……@@ -828,10 +809,10 @@ void ValueSaveUTest::test_incoming()
828809{
829810 logger().info("BEGIN TEST: %s", __FUNCTION__);
830811
831 AtomSpace* as = new AtomSpace();
812 AtomSpacePtr as = createAtomSpace();
832813 Handle hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
833814 StorageNodePtr store = StorageNodeCast(hsn);
834 store->open();
815 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
835816 TS_ASSERT(store->connected())
836817
837818 Handle key = as->add_node(PREDICATE_NODE, "some pred key");
……@@ -910,15 +891,12 @@ void ValueSaveUTest::test_incoming()
910891 store->store_atom(cv);
911892 store->barrier();
912893
913 delete as;
914
915894 // --------------------
916895 // Start it up again.
917
918 as = new AtomSpace();
896 as = createAtomSpace();
919897 hsn = as->add_node(MONO_STORAGE_NODE, std::string(uri));
920898 store = StorageNodeCast(hsn);
921 store->open();
899 store->setValue(as->add_node(PREDICATE_NODE, "*-open-*"), createVoidValue());
922900 TS_ASSERT(store->connected())
923901
924902 // --------------------
……@@ -939,9 +917,10 @@ void ValueSaveUTest::test_incoming()
939917 store->fetch_incoming_set(gal, false);
940918 store->fetch_incoming_set(gav, false);
941919 store->barrier();
942 // +1 for *-IsKeyFlag-*
920 // 17 = 4 LIST_LINKs + 8 ConceptNodes + PredicateNode "some pred key"
921 // + *-TruthValueKey-* + *-IsKeyFlag-* + *-open-* + MonoStorageNode
943922 printf ("fetched %lu atoms\n", as->get_size());
944 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 16);
923 TSM_ASSERT("Wrong number of Atoms fetched!", as->get_size() == 17);
945924
946925 Handle gbf = as->add_node(CONCEPT_NODE, "b float node");
947926 Handle gbt = as->add_node(CONCEPT_NODE, "b string node");
……@@ -1025,9 +1004,6 @@ void ValueSaveUTest::test_incoming()
10251004 TS_ASSERT(*gpl == *pvl);
10261005 TS_ASSERT(*gpv == *pvv);
10271006
1028 // --------------------
1029 delete as;
1030
10311007 logger().info("END TEST: %s", __FUNCTION__);
10321008}
10331009