OverviewFilesCommitsIssuesDocsReleasesPeers

kodi-jacktook commits / 571c69f

Drop the donation prompt and the dead root entries (1.15.2)
Two UI changes, both about getting to content in fewer steps. Donation prompt: upstream 1.15.x calls maybe_show_donation_prompt() from root_menu(), which fires once per ADDON_VERSION. This fork publishes its own versions, so it would nag on every release we cut -- it already fired once on the 1.15.1 install. root_menu() no longer calls it; the function stays defined and the Settings > donate action still works, so nothing is removed, just not forced. Root menu: the box has no torrent client, no debrid or cloud account and no Live TV source, so Live TV / Torrents / Cloud / Downloads were four of eleven rows that could only dead-end. They are filtered at render time against HIDDEN_ROOT_ACTIONS rather than deleted from root_menu_items, so upstream merges stay clean and re-enabling one is a single-line edit. The condition signature used for the menu cache key is computed from the same filtered list, so the cache cannot serve a stale row set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
571c69f25b9bbb31697535a79588aee9ef07f28f
by plankatron <fleeky@gmail.com> · 2026-07-28T20:38:33.000Z

Changed files (3) +16 -4

plugin.video.jacktook/addon.xml +1 -1
……@@ -1,5 +1,5 @@
11<?xml version="1.0" encoding="utf-8"?>
2 <addon id="plugin.video.jacktook" name="Jacktook" version="1.15.1" provider-name="Sam-Max">
2 <addon id="plugin.video.jacktook" name="Jacktook" version="1.15.2" provider-name="Sam-Max">
33 <requires>
44 <import addon="xbmc.python" version="3.00.0"/>
55 <import addon="script.module.requests" version="2.25.1"/>
plugin.video.jacktook/lib/navigation.py +8 -3
……@@ -34,6 +34,7 @@ from lib.utils.general.items_menus import (
3434 anime_items,
3535 movie_items,
3636 root_menu_items,
37 HIDDEN_ROOT_ACTIONS,
3738 trakt_movie_discovery_items,
3839 trakt_movie_library_items,
3940 trakt_tv_discovery_items,
……@@ -383,12 +384,16 @@ def reset_views(params):
383384
384385
385386def root_menu():
386 maybe_show_donation_prompt()
387 # Donation prompt intentionally not shown: it fires once per version, and
388 # this fork publishes its own versions, so it would nag on every release we
389 # cut. maybe_show_donation_prompt() is left defined and reachable via the
390 # Settings > donate action for anyone who wants it.
387391 set_pluging_category(translation(90069))
392 items = [i for i in root_menu_items if i.get("action") not in HIDDEN_ROOT_ACTIONS]
388393 render_menu(
389 root_menu_items,
394 items,
390395 cache=False,
391 cache_key=f"nav.root:{_menu_condition_signature(root_menu_items)}",
396 cache_key=f"nav.root:{_menu_condition_signature(items)}",
392397 )
393398 apply_section_view("view.main")
394399
plugin.video.jacktook/lib/utils/general/items_menus.py +7 -0
……@@ -491,6 +491,13 @@ animation_items = [
491491 },
492492]
493493
494# Root entries this box has no backend for: no torrent client, no debrid or
495# cloud account, no Live TV source. They were five of eleven rows that could
496# only ever dead-end. Filtered at render time in navigation.root_menu() rather
497# than deleted from the list below, so upstream merges stay clean and putting
498# one back is a one-line edit here.
499HIDDEN_ROOT_ACTIONS = {"tv_menu", "torrents", "cloud", "downloads_menu"}
500
494501root_menu_items = [
495502 {
496503 "name": 90006,