27d175d · hyper-booking

hyper-booking commits / 27d175d

Fix sign-in: remove noble ES module script tags, use dynamic import only

Root cause: noble-ed25519.js and noble-sha512.js are ES modules
(use import/export syntax). Loading them as classic <script src> tags
fails silently in browsers. identity.js already loads them via
dynamic import() — the script tags were redundant and broken.

Removed noble <script> tags from all three page templates
(provider landing, booking, dashboard). identity.js handles loading.

Tests updated to verify noble tags are NOT in rendered HTML.
17/17 tests pass, 131 assertions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

27d175d074fdd34f0850f3b55833053f4cb75e16

by plankatron <fleeky@gmail.com> · 2026-03-22T19:11:49.000Z

Changed files (3) +7 -14

lib/routes/dashboard.js +0 -2

…	…	@@ -427,8 +427,6 @@ function serveDashboardPage (res, server, view, params = {}) {
427	427	</main>
428	428	</div>
429	429
430		<script src="${prefix}/web/vendor/noble-ed25519.js"></script>
431		<script src="${prefix}/web/vendor/noble-sha512.js"></script>
432	430	<script src="${prefix}/web/js/identity.js"></script>
433	431	<script src="${prefix}/web/js/app.js"></script>
434	432	<script src="${prefix}/web/js/dashboard.js"></script>

lib/routes/web.js +0 -4

…	…	@@ -98,8 +98,6 @@ export function registerPublicRoutes (router, server) {
98	98	</footer>
99	99	</div>
100	100
101		<script src="${server.pathPrefix}/web/vendor/noble-ed25519.js"></script>
102		<script src="${server.pathPrefix}/web/vendor/noble-sha512.js"></script>
103	101	<script src="${server.pathPrefix}/web/js/identity.js"></script>
104	102	<script src="${server.pathPrefix}/web/js/app.js"></script>
105	103	<script>
…	…	@@ -242,8 +240,6 @@ function renderProviderPage (provider, packages, prefix) {
242	240	</footer>
243	241	</div>
244	242
245		<script src="${prefix}/web/vendor/noble-ed25519.js"></script>
246		<script src="${prefix}/web/vendor/noble-sha512.js"></script>
247	243	<script src="${prefix}/web/js/identity.js"></script>
248	244	<script src="${prefix}/web/js/app.js"></script>
249	245	</body>

test/server.test.js +7 -8

…	…	@@ -529,11 +529,10 @@ test('provider landing page renders HTML', async (t) => {
529	529	const html = res.body
530	530	t.ok(html.includes('Test Coach'))
531	531	t.ok(html.includes('Test Session'))
532		t.ok(html.includes('noble-ed25519.js'))
533		t.ok(html.includes('noble-sha512.js'))
534		t.ok(html.includes('identity.js'))
535		t.ok(html.includes('app.js'))
536		t.ok(html.includes('/test-coach/book/pkg_test1'))
	532	t.ok(html.includes('identity.js'), 'should include identity.js')
	533	t.ok(html.includes('app.js'), 'should include app.js')
	534	t.ok(!html.includes('noble-ed25519.js'), 'should NOT include noble script tags (loaded dynamically)')
	535	t.ok(html.includes('/test-coach/book/pkg_test1'), 'should link to booking page')
537	536	} finally {
538	537	await s.close()
539	538	}
…	…	@@ -551,9 +550,9 @@ test('booking page renders HTML', async (t) => {
551	550
552	551	const html = res.body
553	552	t.ok(html.includes('Test Session'))
554		t.ok(html.includes('noble-ed25519.js'))
555		t.ok(html.includes('identity.js'))
556		t.ok(html.includes('initBookingPage'))
	553	t.ok(html.includes('identity.js'), 'should include identity.js')
	554	t.ok(!html.includes('noble-ed25519.js'), 'should NOT include noble script tags')
	555	t.ok(html.includes('initBookingPage'), 'should call initBookingPage')
557	556	} finally {
558	557	await s.close()
559	558	}