208a01f · godot-keet · pear-git-v3

godot-keet commits / 208a01f

Fix Window signal errors: lambdas → explicit methods, non-transient dialog

- SyncDialog: set transient=false, exclusive=false (stops Godot from
  connecting/disconnecting focus_entered/tree_exited on root viewport)
- Replace close_requested lambda connections with explicit methods in:
  room_settings, group_settings, identity_manager_panel
- Lambdas cause "nonexistent connection" errors on repeated show/hide

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

208a01f948dcad616ec41584edf82a61633f3c7a

by plankatron <fleeky@gmail.com> · 2026-02-23T13:36:54.000Z

Changed files (4) +18 -5

scenes/graph_panel.tscn +2 -2

…	…	@@ -43,8 +43,8 @@ initial_position = 2
43	43	size = Vector2i(480, 220)
44	44	visible = false
45	45	wrap_controls = true
46		transient = true
47		exclusive = true
	46	transient = false
	47	exclusive = false
48	48
49	49	[node name="Margin" type="MarginContainer" parent="SyncDialog"]
50	50	anchors_preset = 15

scripts/group_settings.gd +5 -1

…	…	@@ -39,7 +39,7 @@ var _my_role: String = ""
39	39
40	40
41	41	func _ready() -> void:
42		close_requested.connect(func(): hide())
	42	close_requested.connect(_on_close_requested)
43	43	save_btn.pressed.connect(_on_save)
44	44	change_avatar_btn.pressed.connect(_on_change_avatar)
45	45	create_invite_btn.pressed.connect(_on_create_invite)
…	…	@@ -122,6 +122,10 @@ func _load_avatar() -> void:
122	122	avatar_preview.texture = ImageTexture.create_from_image(img)
123	123
124	124
	125	func _on_close_requested() -> void:
	126	hide()
	127
	128
125	129	func _on_save() -> void:
126	130	save_status.text = "Saving..."
127	131	save_status.remove_theme_color_override("font_color")

scripts/identity_manager_panel.gd +6 -1

…	…	@@ -25,7 +25,7 @@ var _selected_idx: int = -1
25	25
26	26
27	27	func _ready() -> void:
28		close_requested.connect(func(): closed.emit(); hide())
	28	close_requested.connect(_on_close_requested)
29	29	create_btn.pressed.connect(_on_create)
30	30	import_btn.pressed.connect(_on_import)
31	31	export_btn.pressed.connect(_on_export)
…	…	@@ -112,6 +112,11 @@ func _get_selected_id() -> String:
112	112	return ""
113	113
114	114
	115	func _on_close_requested() -> void:
	116	closed.emit()
	117	hide()
	118
	119
115	120	# --- Actions ---
116	121
117	122	func _on_create() -> void:

scripts/room_settings.gd +5 -1

…	…	@@ -45,7 +45,7 @@ var _my_room_role: String = "" # admin, mod, peer, etc.
45	45
46	46
47	47	func _ready() -> void:
48		close_requested.connect(func(): hide())
	48	close_requested.connect(_on_close_requested)
49	49	save_btn.pressed.connect(_on_save)
50	50	invite_btn.pressed.connect(_on_invite)
51	51	change_avatar_btn.pressed.connect(_on_change_avatar)
…	…	@@ -277,6 +277,10 @@ func _parse_topics() -> Array:
277	277	return result
278	278
279	279
	280	func _on_close_requested() -> void:
	281	hide()
	282
	283
280	284	func _on_save() -> void:
281	285	print("[room_settings %s] === _on_save START ===" % SETTINGS_VERSION)
282	286	save_status.text = "Saving..."