af76bbd · atomspace-gpu

Changed files (3) +137 -5

experiments/mi-verify/README.md +34 -0

…	…	@@ -0,0 +1,34 @@
	1	# MI data-verification (Step 1b)
	2
	3	Closes the MI loop against the real opencog engine on real data — the
	4	cornerstone of "reproducible of his results" (`spec/convergence-with-linas.md`).
	5
	6	`mi-verify.scm` builds a tiny word-pair AtomSpace with known counts, runs opencog's
	7	`matrix` `batch-all-pair-mi`, reads each pair's `pair-fmi`
	8	(= `log₂[P(x,y)/(P(x,)P(,y))]`, the pointwise MI), and compares to our
	9	`cpu_mi = log₂(count·N/(Nx·Ny))` — the formula our GPU `gpu-mi.cl` kernel is
	10	verified `==` (atomese-simd `test-mi.c`, 6/6 PASS on the RTX 2070).
	11
	12	## Run
	13	```bash
	14	# from opencog-kb/repos/ (so (opencog matrix) resolves)
	15	guile -l atomspace-gpu/experiments/mi-verify/mi-verify.scm -c '(exit 0)'
	16	# -> MI DATA-VERIFY PASS: opencog pair-fmi == cpu_mi (== our GPU kernel)
	17	```
	18
	19	## Result (2026-07-05)
	20	\| pair \| count \| N(x,) \| N(,y) \| opencog fmi \| cpu_mi \| diff \|
	21	\|---\|---\|---\|---\|---\|---\|---\|
	22	\| the-cat \| 2 \| 3 \| 3 \| −0.169925 \| −0.169925 \| 2.8e-17 \|
	23	\| the-dog \| 1 \| 3 \| 1 \| 0.415037 \| 0.415037 \| 2.2e-16 \|
	24	\| a-cat \| 1 \| 1 \| 3 \| 0.415037 \| 0.415037 \| 2.2e-16 \|
	25
	26	Epsilon-level agreement ⇒ GPU kernel == cpu_mi == opencog `pair-fmi` on real data.
	27
	28	## Gotchas (verified)
	29	- opencog has TWO MI getters: `pair-mi` (count-weighted `P·log₂[…]`) and `pair-fmi`
	30	(pointwise `log₂[…]`). Ours matches `pair-fmi` — comparing to `pair-mi` would
	31	falsely mismatch.
	32	- Count convention: `make-basic-api` reads the count at `FloatValue` index 2 of the
	33	`(Predicate "counter")` value.
	34	- `batch-all-pair-mi OBJ #f` computes in-RAM (no StorageNode needed).

experiments/mi-verify/mi-verify.scm +96 -0

…	…	@@ -0,0 +1,96 @@
	1	; mi-verify.scm — data-level MI tie: opencog matrix `pair-fmi` vs our cpu_mi.
	2	; Tiny hand-computable word-pair dataset -> batch-all-pair-mi -> read pair-fmi,
	3	; compare to log2(countN/(Nx·N*y)) which our GPU kernel is verified == to.
	4
	5	(use-modules (srfi srfi-1))
	6	(use-modules (opencog) (opencog matrix))
	7
	8	; --- make-basic-api (verbatim from matrix/tests/matrix/basic-api.scm) ---
	9	(define (make-basic-api)
	10	(define (get-left-type) 'ConceptNode)
	11	(define (get-right-type) 'ConceptNode)
	12	(define (get-pair-type) 'EvaluationLink)
	13	(define (get-pair L-ATOM R-ATOM)
	14	(define maybe-list (cog-link 'ListLink L-ATOM R-ATOM))
	15	(if (not maybe-list) '()
	16	(cog-link 'EvaluationLink (Predicate "foo") maybe-list)))
	17	(define (get-count PAIR)
	18	(cog-value-ref (cog-value PAIR (Predicate "counter")) 2))
	19	(define (get-pair-count L-ATOM R-ATOM)
	20	(define stats-atom (get-pair L-ATOM R-ATOM))
	21	(if (not stats-atom) 0 (get-count stats-atom)))
	22	(define (make-pair L-ATOM R-ATOM)
	23	(EvaluationLink (Predicate "foo") (List L-ATOM R-ATOM)))
	24	(define (get-left-element PAIR) (gadr PAIR))
	25	(define (get-right-element PAIR) (gddr PAIR))
	26	(define (get-left-wildcard ITEM)
	27	(EvaluationLink (Predicate "foo") (ListLink (AnyNode "left-wild") ITEM)))
	28	(define (get-right-wildcard ITEM)
	29	(EvaluationLink (Predicate "foo") (ListLink ITEM (AnyNode "right-wild"))))
	30	(define (get-wild-wild)
	31	(EvaluationLink (Predicate "foo") (ListLink (AnyNode "left-wild") (AnyNode "right-wild"))))
	32	(define (fetch-all-pairs) '())
	33	(lambda (message . args)
	34	(apply (case message
	35	((name) (lambda () "MI verify demo"))
	36	((id) (lambda () "mi-verify"))
	37	((left-type) get-left-type)
	38	((right-type) get-right-type)
	39	((pair-type) get-pair-type)
	40	((pair-count) get-pair-count)
	41	((get-pair) get-pair)
	42	((get-count) get-count)
	43	((make-pair) make-pair)
	44	((left-element) get-left-element)
	45	((right-element) get-right-element)
	46	((left-wildcard) get-left-wildcard)
	47	((right-wildcard) get-right-wildcard)
	48	((wild-wild) get-wild-wild)
	49	((fetch-pairs) fetch-all-pairs)
	50	((provides) (lambda (symb) #f))
	51	((filters?) (lambda () #f))
	52	(else (error "Bad method call on low-level API")))
	53	args)))
	54
	55	(define bapi (make-basic-api))
	56	(define sapi (add-pair-stars bapi))
	57	(define fapi (add-pair-freq-api sapi))
	58
	59	; --- tiny dataset: (left right count) ---
	60	(define data '(("the" "cat" 2.0) ("the" "dog" 1.0) ("a" "cat" 1.0)))
	61
	62	; set a count on a pair the way the basic-api reads it (FloatValue index 2)
	63	(define (observe L R cnt)
	64	(define p (bapi 'make-pair (Concept L) (Concept R)))
	65	(cog-set-value! p (Predicate "counter") (FloatValue 0 0 cnt))
	66	p)
	67	(for-each (lambda (row) (apply observe row)) data)
	68
	69	; --- opencog computes marginals, freqs, entropies, MI (in-RAM, no store) ---
	70	(batch-all-pair-mi bapi #f)
	71
	72	; --- our reference marginals from the raw counts (hand/independent) ---
	73	(define (log2 x) (/ (log x) (log 2)))
	74	(define N (fold + 0 (map caddr data)))
	75	(define (Nx* L) (fold + 0 (map caddr (filter (lambda (r) (string=? (car r) L)) data))))
	76	(define (N*y R) (fold + 0 (map caddr (filter (lambda (r) (string=? (cadr r) R)) data))))
	77	(define (cpu-fmi L R cnt) (log2 (/ (* cnt N) (* (Nx* L) (N*y R)))))
	78
	79	; --- compare opencog pair-fmi vs cpu-fmi for each pair ---
	80	(define tol 1e-6)
	81	(define all-ok #t)
	82	(display "pair count Nx* N*y opencog-fmi cpu-fmi diff\n")
	83	(for-each
	84	(lambda (row)
	85	(define L (car row)) (define R (cadr row)) (define cnt (caddr row))
	86	(define p (bapi 'get-pair (Concept L) (Concept R)))
	87	(define oc (fapi 'pair-fmi p))
	88	(define cpu (cpu-fmi L R cnt))
	89	(define d (abs (- oc cpu)))
	90	(if (> d tol) (set! all-ok #f))
	91	(format #t "~a-~a\t ~a ~a ~a ~9,6f ~9,6f ~9,2e\n"
	92	L R cnt (Nx* L) (N*y R) oc cpu d))
	93	data)
	94	(newline)
	95	(display (if all-ok "MI DATA-VERIFY PASS: opencog pair-fmi == cpu_mi (== our GPU kernel)\n"
	96	"MI DATA-VERIFY FAIL\n"))

spec/convergence-with-linas.md +7 -5

…	…	@@ -113,11 +113,13 @@ Both prongs share one verification target per primitive.
113	113	and diff the actual numbers (Step 1b).
114	114
115	115	## Next steps (ordered, verification-first)
116		1. MI: prove the kernel runs + data-verify `== opencog`. (a) ✅ DONE 2026-07-05 —
117		`test-mi.c` builds & runs on the RTX 2070, 6/6 PASS, GPU MI `== cpu_mi`. (b) reproduce
118		the SAME counts through opencog's `matrix` (`batch-all-pair-mi`) in guile and diff the
119		numbers against the GPU output. Converts formula-verified → data-verified. THE
120		cornerstone of "reproducible of his results."
	116	1. MI: prove the kernel runs + data-verify `== opencog`. ✅ DONE 2026-07-05.
	117	(a) `test-mi.c` builds & runs on the RTX 2070, 6/6 PASS, GPU MI `== cpu_mi`.
	118	(b) `experiments/mi-verify/mi-verify.scm` — opencog `batch-all-pair-mi` → `pair-fmi`
	119	on a tiny hand-computable dataset `== cpu_mi` to fp epsilon (~1e-16). **Chain closed
	120	on real data: GPU == cpu_mi == opencog `pair-fmi`.** (Key gotcha: compare to `pair-fmi`,
	121	the pointwise MI, NOT `pair-mi`, the count-weighted one.) This is the cornerstone of
	122	"reproducible of his results" — the MI primitive is fully data-verified.
121	123	2. Audit `gpu-sections.cl` — is its test tied to real `learn` pseudo-csets
122	124	(Section = word + ConnectorSeq, count on the Section)? Tie or fix.
123	125	3. Audit `gpu-connector-rewrite.cu` — does it implement the pre-sheaf

atomspace-gpu commits / af76bbd

Changed files (3) +137 -5